Updated usage of ImageCleaner #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DatasetFormatter.from_toplosses removed the `ds_type` parameter. In order to clean the whole dataset we need to create a separate one with all the images. This commit alters the notebook to reflect the new approach. Some students, including myself, ran into an issue when ImageCleaner didn't render at all. This happens when using Jupyter Lab instead of Jupyter Notebook. I've added the warning to the notebook as well. It also fixes an issue with creating ImageDataBunch from `cleaned.csv`. The first param was `"."`, the current folder, but should be `path`. This commit fixes it.
Updated the name of the object due to the recent changes to the library.
jph00
requested changes
Mar 12, 2019
nbs/dl1/lesson2-download.ipynb
Outdated
| { | ||
| "cell_type": "code", | ||
| "execution_count": null, | ||
| "metadata": {}, | ||
| "outputs": [], | ||
| "source": [ | ||
| "ds, idxs = DatasetFormatter().from_toplosses(learn, ds_type=DatasetType.Valid)" | ||
| "learn_cln = create_cnn(db, models.resnet34, metrics=error_rate)\n", |
nbs/dl1/lesson2-download.ipynb
Outdated
| "cell_type": "markdown", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "Make sure you're running this notebook in Jupyter Notebook, not Jupyter Lab. That is accessible via https://localhost:8080/tree, not https://localhost:8080/lab. Running the `ImageCleaner` widget in Jupyter Lab is [not currently supported](https://github.com/fastai/fastai/issues/1539)." |
There was a problem hiding this comment.
That is only the URL for some systems, but is not correct for all systems.
There was a problem hiding this comment.
I changed the links to the relative ones (/lab and /tree). It should work in most cases, I think. Should I remove them altogether to be on the safe side?
mattcallanan
pushed a commit
to mattcallanan/course-v3
that referenced
this pull request
Apr 2, 2019
* Updated usage of ImageCleaner
DatasetFormatter.from_toplosses removed the `ds_type` parameter.
In order to clean the whole dataset we need to create a separate
one with all the images. This commit alters the notebook
to reflect the new approach.
Some students, including myself, ran into an issue when ImageCleaner
didn't render at all. This happens when using Jupyter Lab instead
of Jupyter Notebook. I've added the warning to the notebook as well.
It also fixes an issue with creating ImageDataBunch from `cleaned.csv`.
The first param was `"."`, the current folder, but should be `path`.
This commit fixes it.
* ImageItemList to ImageList
Updated the name of the object due to the recent changes
to the library.
* PR fixes
* Updates `create_cnn` to `cnn_learner` as the name changed in the newer
version of the library.
* Changes links to Notebook and Lab to more general ones (relative).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DatasetFormatter.from_toplosses removed the
ds_typeparameter.In order to clean the whole dataset we need to create a separate
one with all the images. This commit alters the notebook
to reflect the new approach.
Some students, including myself, ran into an issue when ImageCleaner
didn't render at all. This happens when using Jupyter Lab instead
of Jupyter Notebook. I've added the warning to the notebook as well.
It also fixes an issue with creating ImageDataBunch from
cleaned.csv.The first param was
".", the current folder, but should bepath.This commit fixes it.